Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 16, 2025


PR-Codex overview

This PR focuses on updating the tools used in the MCP (Multi-Chain Payment) system, specifically replacing instances of getPaymentHistory, createToken, and others with listDiscoveryResources. It also modifies prompts and URLs for better integration with the new tool.

Detailed summary

  • Removed getPaymentHistory, createToken, listTokens, getTokenOwners.
  • Added listDiscoveryResources.
  • Updated the example to filter MCP tools to include listDiscoveryResources.
  • Modified URL in mcpServers to use listDiscoveryResources.
  • Changed prompts in createReactAgent to refer to listDiscoveryResources.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation
    • Added a new resource discovery tool to the available MCP tools roster
    • Updated API documentation, agent instructions, and code examples (TypeScript, Python, curl) to use the new discovery tool for endpoint discovery
    • Refined wallet parameter handling in API examples with clearer default behavior documentation

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 16, 2025 7:49am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Oct 16, 2025 7:49am
thirdweb_playground Skipped Skipped Oct 16, 2025 7:49am
thirdweb-www Skipped Skipped Oct 16, 2025 7:49am
wallet-ui Skipped Skipped Oct 16, 2025 7:49am

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: 770c053

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2025 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 16, 2025 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2025 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 16, 2025 07:26 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 16, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the _Docs_Update_X402_agent_example_to_use_listDiscoveryResources_instead_of_getWalletBalance branch from 8a29cf5 to 770c053 Compare October 16, 2025 07:26
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2025 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2025 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 16, 2025 07:26 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

Documentation updates replace getWalletBalance with listDiscoveryResources in MCP tools documentation and agent examples. Updates include tool roster, code samples in TypeScript/Python/curl, agent prompts, and API usage descriptions across two documentation files.

Changes

Cohort / File(s) Summary
MCP Tools Documentation
apps/portal/src/app/ai/mcp/page.mdx
Added listDiscoveryResources to the publicly available MCP tools roster.
Payment Agent Documentation
apps/portal/src/app/payments/x402/agents/page.mdx
Replaced getWalletBalance with listDiscoveryResources in MCP tool filter, updated agent prompts to reference tool-based endpoint discovery, revised code examples (TypeScript, Python, curl), and updated API usage section to reflect default project wallet behavior with optional from parameter override.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes the template placeholders but none of the required sections have been completed with actual content, leaving out the title, reviewer notes, and testing instructions, so it does not satisfy the repository’s description template. Please replace the template comments with a filled-out title in the specified format, add meaningful notes for reviewers, and include clear how-to-test instructions under the appropriate headings.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly describes the main documentation change by specifying the X402 agent example update to use listDiscoveryResources and includes the appropriate [Docs] tag, making it concise, specific, and aligned with the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _Docs_Update_X402_agent_example_to_use_listDiscoveryResources_instead_of_getWalletBalance

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 16, 2025 07:26 Inactive
@joaquim-verges joaquim-verges changed the title [Docs] Update X402 agent example to use listDiscoveryResources instead of getWalletBalance [Docs] Update X402 agent example to use listDiscoveryResources Oct 16, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review October 16, 2025 07:26
@joaquim-verges joaquim-verges requested review from a team as code owners October 16, 2025 07:26
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.01%. Comparing base (5f11ae0) to head (770c053).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8265      +/-   ##
==========================================
- Coverage   55.03%   55.01%   -0.02%     
==========================================
  Files         919      919              
  Lines       60583    60588       +5     
  Branches     4131     4126       -5     
==========================================
- Hits        33341    33334       -7     
- Misses      27138    27150      +12     
  Partials      104      104              
Flag Coverage Δ
packages 55.01% <ø> (-0.02%) ⬇️
see 5 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.51 KB (0%) 1.3 s (0%) 183 ms (+219.78% 🔺) 1.5 s
thirdweb (cjs) 365.68 KB (0%) 7.4 s (0%) 570 ms (+19.96% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 100 ms (+3330.44% 🔺) 215 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 38 ms (+2141.6% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 61 ms (+2322.32% 🔺) 443 ms

@joaquim-verges joaquim-verges merged commit 2779afc into main Oct 16, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the _Docs_Update_X402_agent_example_to_use_listDiscoveryResources_instead_of_getWalletBalance branch October 16, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants